[Asterisk-code-review] Fix for ASTERISK-27046. (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Thu Jun 8 20:35:55 CDT 2017


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5789 )

Change subject: Fix for ASTERISK-27046.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5789/1//COMMIT_MSG
Commit Message:

Line 7: Fix for ASTERISK-27046.
Please follow the commit message guidelines:
https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


https://gerrit.asterisk.org/#/c/5789/1/res/res_pjsip_transport_websocket.c
File res/res_pjsip_transport_websocket.c:

Line 308: 			if ((transport = ast_sorcery_retrieve_by_id(ast_sip_get_sorcery(), "transport", transport_state->id)) {
Please avoid putting assignments if tests.
As it is you have an unbalanced closing parentheses syntax error because of it.


-- 
To view, visit https://gerrit.asterisk.org/5789
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9357717278da631c3a1cb502c412693929b0cb41
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jørgen H <asterisk.org at hovland.cx>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list