[Asterisk-code-review] Fix for ASTERISK-27046. (asterisk[master])

Jørgen H asteriskteam at digium.com
Thu Jun 8 17:34:13 CDT 2017


Jørgen H has uploaded a new change for review. ( https://gerrit.asterisk.org/5789 )

Change subject: Fix for ASTERISK-27046.
......................................................................

Fix for ASTERISK-27046.

Added check for NULL return value when calling
ast_sorcery_retrieve_by_id in function get_write_timeout

Change-Id: I9357717278da631c3a1cb502c412693929b0cb41
---
M res/res_pjsip_transport_websocket.c
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/89/5789/1

diff --git a/res/res_pjsip_transport_websocket.c b/res/res_pjsip_transport_websocket.c
index b3e63fc..6e4062e 100644
--- a/res/res_pjsip_transport_websocket.c
+++ b/res/res_pjsip_transport_websocket.c
@@ -305,11 +305,12 @@
 			if (transport_state->type != AST_TRANSPORT_WS && transport_state->type != AST_TRANSPORT_WSS) {
 				continue;
 			}
-			transport = ast_sorcery_retrieve_by_id(ast_sip_get_sorcery(), "transport", transport_state->id);
-			ast_debug(5, "Found %s transport with write timeout: %d\n",
-				transport->type == AST_TRANSPORT_WS ? "WS" : "WSS",
-				transport->write_timeout);
-			write_timeout = MAX(write_timeout, transport->write_timeout);
+			if ((transport = ast_sorcery_retrieve_by_id(ast_sip_get_sorcery(), "transport", transport_state->id)) {
+				ast_debug(5, "Found %s transport with write timeout: %d\n",
+					transport->type == AST_TRANSPORT_WS ? "WS" : "WSS",
+					transport->write_timeout);
+				write_timeout = MAX(write_timeout, transport->write_timeout);
+			}
 		}
 		ao2_iterator_destroy(&it_transport_states);
 		ao2_cleanup(transport_states);

-- 
To view, visit https://gerrit.asterisk.org/5789
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9357717278da631c3a1cb502c412693929b0cb41
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jørgen H <asterisk.org at hovland.cx>



More information about the asterisk-code-review mailing list