[Asterisk-code-review] chan pjsip: add a new function PJSIP DTMF MODE (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5909 )

Change subject: chan_pjsip: add a new function PJSIP_DTMF_MODE
......................................................................


Patch Set 13:

(8 comments)

All of my comments relate to code formatting/style.

https://gerrit.asterisk.org/#/c/5909/13/channels/chan_pjsip.c
File channels/chan_pjsip.c:

https://gerrit.asterisk.org/#/c/5909/13/channels/chan_pjsip.c@a1837
PS13, Line 1837: 
Bring back this blank line.


https://gerrit.asterisk.org/#/c/5909/13/channels/chan_pjsip.c@a1841
PS13, Line 1841: 
Bring back this blank line.


https://gerrit.asterisk.org/#/c/5909/13/channels/pjsip/dialplan_functions.c
File channels/pjsip/dialplan_functions.c:

https://gerrit.asterisk.org/#/c/5909/13/channels/pjsip/dialplan_functions.c@1195
PS13, Line 1195: 	if (channel->session->dsp){
Space before {


https://gerrit.asterisk.org/#/c/5909/13/channels/pjsip/dialplan_functions.c@1198
PS13, Line 1198: 	if ((channel->session->dtmf == AST_SIP_DTMF_INBAND) ||
               : 		(channel->session->dtmf == AST_SIP_DTMF_AUTO)) {
The inner parens are unnecessary and just make it noisy.


https://gerrit.asterisk.org/#/c/5909/13/channels/pjsip/dialplan_functions.c@1220
PS13, Line 1220: 
Remove blank line


https://gerrit.asterisk.org/#/c/5909/13/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/#/c/5909/13/include/asterisk/res_pjsip.h@2911
PS13, Line 2911:  * \since 13.16.0
13.18.0


https://gerrit.asterisk.org/#/c/5909/13/include/asterisk/res_pjsip.h@2926
PS13, Line 2926:  * \since 13.16.0
13.18.0


https://gerrit.asterisk.org/#/c/5909/13/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/5909/13/res/res_pjsip.c@4450
PS13, Line 4450: 
Remove one of the two blank lines



-- 
To view, visit https://gerrit.asterisk.org/5909
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I20eef5da3e5d1d3e58b304416bc79683f87e7612
Gerrit-Change-Number: 5909
Gerrit-PatchSet: 13
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 25 Jul 2017 11:35:15 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170725/21d2eec8/attachment.html>