<p>Sean Bright <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5909">View Change</a></p><p>Patch set 13:</p><p style="white-space: pre-wrap; word-wrap: break-word;">All of my comments relate to code formatting/style.</p><p>(8 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5909/13/channels/chan_pjsip.c">File channels/chan_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5909/13/channels/chan_pjsip.c@a1837">Patch Set #13, Line 1837:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Bring back this blank line.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5909/13/channels/chan_pjsip.c@a1841">Patch Set #13, Line 1841:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Bring back this blank line.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/5909/13/channels/pjsip/dialplan_functions.c">File channels/pjsip/dialplan_functions.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5909/13/channels/pjsip/dialplan_functions.c@1195">Patch Set #13, Line 1195:</a> <code style="font-family:monospace,monospace"> if (channel->session->dsp){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Space before {</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5909/13/channels/pjsip/dialplan_functions.c@1198">Patch Set #13, Line 1198:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if ((channel->session->dtmf == AST_SIP_DTMF_INBAND) ||<br>          (channel->session->dtmf == AST_SIP_DTMF_AUTO)) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The inner parens are unnecessary and just make it noisy.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5909/13/channels/pjsip/dialplan_functions.c@1220">Patch Set #13, Line 1220:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove blank line</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/5909/13/include/asterisk/res_pjsip.h">File include/asterisk/res_pjsip.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5909/13/include/asterisk/res_pjsip.h@2911">Patch Set #13, Line 2911:</a> <code style="font-family:monospace,monospace"> * \since 13.16.0</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">13.18.0</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5909/13/include/asterisk/res_pjsip.h@2926">Patch Set #13, Line 2926:</a> <code style="font-family:monospace,monospace"> * \since 13.16.0</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">13.18.0</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/5909/13/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5909/13/res/res_pjsip.c@4450">Patch Set #13, Line 4450:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove one of the two blank lines</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5909">change 5909</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5909"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I20eef5da3e5d1d3e58b304416bc79683f87e7612 </div>
<div style="display:none"> Gerrit-Change-Number: 5909 </div>
<div style="display:none"> Gerrit-PatchSet: 13 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 25 Jul 2017 11:35:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>