[Asterisk-code-review] core: Add PARSE TIMELEN support to ast parse arg and ACO. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5983 )

Change subject: core: Add PARSE_TIMELEN support to ast_parse_arg and ACO.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5983/3/configs/samples/config_test.conf.sample
File configs/samples/config_test.conf.sample:

https://gerrit.asterisk.org/#/c/5983/3/configs/samples/config_test.conf.sample@9
PS3, Line 9: timelenopt=1s
How about 'h' or 'm' tests as well?


https://gerrit.asterisk.org/#/c/5983/3/tests/test_config.c
File tests/test_config.c:

https://gerrit.asterisk.org/#/c/5983/3/tests/test_config.c@1241
PS3, Line 1241: 	TEST_PARSE("123s", EXPECT_SUCCEED, 123000, PARSE_TIMELEN, &timelen_val, TIMELEN_MILLISECONDS);
              : 	TEST_PARSE("-123s", EXPECT_SUCCEED, -123000, PARSE_TIMELEN, &timelen_val, TIMELEN_MILLISECONDS);
              : 	TEST_PARSE("1m", EXPECT_SUCCEED, 60000, PARSE_TIMELEN, &timelen_val, TIMELEN_MILLISECONDS);
How about some tests for 'h' and 'm'.  I know that code itself wasn't touched but it'd make things more complete here.



-- 
To view, visit https://gerrit.asterisk.org/5983
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b333feca7e3f83b4ef5bf2636fc0fd613742554
Gerrit-Change-Number: 5983
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 13 Jul 2017 14:34:53 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170713/1c6bc5d6/attachment-0001.html>