[Asterisk-code-review] res/res stasis snoop: generate silence when audiohook return... (asterisk[14])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5989 )

Change subject: res/res_stasis_snoop: generate silence when audiohook returns null
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5989/1/res/res_stasis_snoop.c
File res/res_stasis_snoop.c:

https://gerrit.asterisk.org/#/c/5989/1/res/res_stasis_snoop.c@403
PS1, Line 403: 		snoop->silence.data.ptr = ast_calloc(snoop->spy_samples, sizeof(uint16_t));
If this allocation fails then the frame will actually result in PLC instead of silence. This should check if it failed and stop the Snoop channel, since the behavior won't be the same.



-- 
To view, visit https://gerrit.asterisk.org/5989
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d7f60650457860b9c70907b14426756b058a844
Gerrit-Change-Number: 5989
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 12 Jul 2017 16:11:54 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170712/f7b33304/attachment.html>