<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5989">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5989/1/res/res_stasis_snoop.c">File res/res_stasis_snoop.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5989/1/res/res_stasis_snoop.c@403">Patch Set #1, Line 403:</a> <code style="font-family:monospace,monospace">              snoop->silence.data.ptr = ast_calloc(snoop->spy_samples, sizeof(uint16_t));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If this allocation fails then the frame will actually result in PLC instead of silence. This should check if it failed and stop the Snoop channel, since the behavior won't be the same.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5989">change 5989</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5989"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 14 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2d7f60650457860b9c70907b14426756b058a844 </div>
<div style="display:none"> Gerrit-Change-Number: 5989 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 12 Jul 2017 16:11:54 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>