[Asterisk-code-review] app queue: Add change priority of call (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/5881 )

Change subject: app_queue: Add change priority of call
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/#/c/5881/1/apps/app_queue.c
File apps/app_queue.c:

https://gerrit.asterisk.org/#/c/5881/1/apps/app_queue.c@1014
PS1, Line 1014: 			Change priority caller on queue.
s/priority caller/priority of a caller/


https://gerrit.asterisk.org/#/c/5881/1/apps/app_queue.c@7272
PS1, Line 7272: 	}		 
red blob


https://gerrit.asterisk.org/#/c/5881/1/apps/app_queue.c@10268
PS1, Line 10268: 	 } else if (ast_strlen_zero(priority_s)) {
               : 		astman_send_error(s, m, "'Priority' need integer.");
               : 		return 0;
This second check is a duplicate of the first, so can be removed.


https://gerrit.asterisk.org/#/c/5881/1/apps/app_queue.c@10284
PS1, Line 10284: 		astman_send_error(s, m, "Unable to change priority caller on queue: No such queue");
This should be "no caller"


https://gerrit.asterisk.org/#/c/5881/1/apps/app_queue.c@10493
PS1, Line 10493: 			"       Remove a specific channel from a queue.\n";
"Change the priority of a channel on a queue"



-- 
To view, visit https://gerrit.asterisk.org/5881
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55d520d71cc1cefe9a9b81fefaefc14679e96133
Gerrit-Change-Number: 5881
Gerrit-PatchSet: 1
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 11 Jul 2017 22:58:11 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170711/ad7fcbf7/attachment-0001.html>