<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5881">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(5 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5881/1/apps/app_queue.c">File apps/app_queue.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5881/1/apps/app_queue.c@1014">Patch Set #1, Line 1014:</a> <code style="font-family:monospace,monospace">                   Change priority caller on queue.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/priority caller/priority of a caller/</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5881/1/apps/app_queue.c@7272">Patch Set #1, Line 7272:</a> <code style="font-family:monospace,monospace">   }                </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">red blob</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5881/1/apps/app_queue.c@10268">Patch Set #1, Line 10268:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">   } else if (ast_strlen_zero(priority_s)) {<br>            astman_send_error(s, m, "'Priority' need integer.");<br>                return 0;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This second check is a duplicate of the first, so can be removed.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5881/1/apps/app_queue.c@10284">Patch Set #1, Line 10284:</a> <code style="font-family:monospace,monospace">          astman_send_error(s, m, "Unable to change priority caller on queue: No such queue");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be "no caller"</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5881/1/apps/app_queue.c@10493">Patch Set #1, Line 10493:</a> <code style="font-family:monospace,monospace">                      "       Remove a specific channel from a queue.\n";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"Change the priority of a channel on a queue"</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5881">change 5881</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5881"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I55d520d71cc1cefe9a9b81fefaefc14679e96133 </div>
<div style="display:none"> Gerrit-Change-Number: 5881 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rodrigo Ramirez Norambuena <a@rodrigoramirez.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 11 Jul 2017 22:58:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>