[Asterisk-code-review] res musiconhold: Add kill escalation delay, kill method to ... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5984 )

Change subject: res_musiconhold:  Add kill_escalation_delay, kill_method to class
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5984/4/res/res_musiconhold.c
File res/res_musiconhold.c:

https://gerrit.asterisk.org/#/c/5984/4/res/res_musiconhold.c@1634
PS4, Line 1634: 		killpid(class->pid, class->kill_delay, class->kill_method);
              : 		class->pid = 0;
You still need to save off the class->pid value so the debug message below will have a pid value to report.

pid = class->pid;
class->pid = 0;
killpid(pid, class->kill_delay, class->kill_method);
...
ast_debug(1, "mpg123...", pid...);


https://gerrit.asterisk.org/#/c/5984/4/res/res_musiconhold.c@1772
PS4, Line 1772: 				if (sscanf(var->value, "%zu", &class->kill_delay) == 1) {
Should probably have a minimum 100ms delay or block 0 as the value at a minimum.  The user could currently set the delay to 0.



-- 
To view, visit https://gerrit.asterisk.org/5984
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff70a1a9405685a9021a68416830c0db5158603b
Gerrit-Change-Number: 5984
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 11 Jul 2017 17:20:19 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170711/4afefc29/attachment.html>