<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5984">View Change</a></p><p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5984/4/res/res_musiconhold.c">File res/res_musiconhold.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5984/4/res/res_musiconhold.c@1634">Patch Set #4, Line 1634:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">             killpid(class->pid, class->kill_delay, class->kill_method);<br>          class->pid = 0;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You still need to save off the class->pid value so the debug message below will have a pid value to report.</p><p style="white-space: pre-wrap; word-wrap: break-word;">pid = class->pid;<br>class->pid = 0;<br>killpid(pid, class->kill_delay, class->kill_method);<br>...<br>ast_debug(1, "mpg123...", pid...);</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5984/4/res/res_musiconhold.c@1772">Patch Set #4, Line 1772:</a> <code style="font-family:monospace,monospace">                               if (sscanf(var->value, "%zu", &class->kill_delay) == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should probably have a minimum 100ms delay or block 0 as the value at a minimum.  The user could currently set the delay to 0.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5984">change 5984</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5984"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iff70a1a9405685a9021a68416830c0db5158603b </div>
<div style="display:none"> Gerrit-Change-Number: 5984 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 11 Jul 2017 17:20:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>