[Asterisk-code-review] res rtp asterisk.c: Fix TURN deadlock by using ICE session g... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5973 )

Change subject: res_rtp_asterisk.c: Fix TURN deadlock by using ICE session group lock.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5973/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/5973/1/res/res_rtp_asterisk.c@1364
PS1, Line 1364: 		turn_sock_cfg.grp_lock = ice->real_ice->grp_lock;
> I'm no ao2 expert, but I'd imagine you'd want to ao2_ref before using the i
That won't make any difference.  We can get a ref for ice any time until we ao2_unlock(instance).  The reason we even get a ref for ice is to ensure that the group lock pointer won't get destroyed on us until pj_turn_sock_create() associates itself with the group lock.



-- 
To view, visit https://gerrit.asterisk.org/5973
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic870edb99ce4988a8c8eb6e678ca7f19da1432b9
Gerrit-Change-Number: 5973
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Michael Walton <mike at farsouthnet.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 06 Jul 2017 22:18:12 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170706/3a5a2722/attachment.html>