<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5973">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5973/1/res/res_rtp_asterisk.c">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5973/1/res/res_rtp_asterisk.c@1364">Patch Set #1, Line 1364:</a> <code style="font-family:monospace,monospace">           turn_sock_cfg.grp_lock = ice->real_ice->grp_lock;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I'm no ao2 expert, but I'd imagine you'd want to ao2_ref before using the i</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">That won't make any difference.  We can get a ref for ice any time until we ao2_unlock(instance).  The reason we even get a ref for ice is to ensure that the group lock pointer won't get destroyed on us until pj_turn_sock_create() associates itself with the group lock.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5973">change 5973</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5973"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic870edb99ce4988a8c8eb6e678ca7f19da1432b9 </div>
<div style="display:none"> Gerrit-Change-Number: 5973 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Michael Walton <mike@farsouthnet.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 06 Jul 2017 22:18:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>