[Asterisk-code-review] stasis channels.c: Misc cleanup. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7761 )

Change subject: stasis_channels.c: Misc cleanup.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7761/1/main/stasis_channels.c
File main/stasis_channels.c:

https://gerrit.asterisk.org/#/c/7761/1/main/stasis_channels.c@175
PS1, Line 175: static int channel_snapshot_hash_cb(const void *obj, const int flags)
> We need case insensitive variants of the AO2_STRING_FIELD_* macros so they 
Well, generic macros could be created that parameterize the hash and compare functions.  Then the existing macros could call the more generic macros.  Something like that should be done in its own review though rather than creeping the scope of reviews like this.



-- 
To view, visit https://gerrit.asterisk.org/7761
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c405518cab22aa2a082b61e2353bf7cd629a70
Gerrit-Change-Number: 7761
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 28 Dec 2017 21:48:54 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171228/0970e925/attachment.html>