[Asterisk-code-review] stasis channels.c: Misc cleanup. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7761 )

Change subject: stasis_channels.c: Misc cleanup.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/7761/1/main/stasis_channels.c
File main/stasis_channels.c:

https://gerrit.asterisk.org/#/c/7761/1/main/stasis_channels.c@175
PS1, Line 175: static int channel_snapshot_hash_cb(const void *obj, const int flags)
We need case insensitive variants of the AO2_STRING_FIELD_* macros so they can be used for this.  Up to you if you want to include that in this review or leave it to later, but I think we should try to remove duplication of this source pattern.



-- 
To view, visit https://gerrit.asterisk.org/7761
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c405518cab22aa2a082b61e2353bf7cd629a70
Gerrit-Change-Number: 7761
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Thu, 28 Dec 2017 20:43:00 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171228/a73071b8/attachment-0001.html>