[Asterisk-code-review] pjsip: Rewrite OPTIONS support with new eyes. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7710 )

Change subject: pjsip: Rewrite OPTIONS support with new eyes.
......................................................................


Patch Set 1:

(2 comments)

I'm not familiar with any of this code but I'll do my best to give a proper review later.  For now I just wanted to mention a couple things that I noticed right away.

I'm not applying a vote because I don't want others to see the -1 and skip over the review.

https://gerrit.asterisk.org/#/c/7710/1/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/#/c/7710/1/include/asterisk/res_pjsip.h@306
PS1, Line 306: 	/*! UNUSED: The round trip start time set before sending a qualify request */
The ABI of 'struct ast_sip_contact_status' is broken by removal of SORCERY_OBJECT(details) and addition of name.  Assuming that's unavailable why not also remove rtt_start and refresh?  If these fields will be used again in the future of 13 then lets say 'RESERVED' instead of 'UNUSED'.


https://gerrit.asterisk.org/#/c/7710/1/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

PS1: 
sip_contact_hash and sip_contact_cmp can be replaced by ast_sorcery_object_id_hash and ast_sorcery_object_id_compare.

The remaining container hash/cmp functions can be generated by macro's AO2_STRING_FIELD_HASH_FN and AO2_STRING_FIELD_CMP_FN.



-- 
To view, visit https://gerrit.asterisk.org/7710
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a5ebbfca9001dfe933eaeac4d3babd8d2e6f082
Gerrit-Change-Number: 7710
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 25 Dec 2017 16:44:43 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171225/3b3f2b44/attachment.html>