<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7710">View Change</a></p><p>Patch set 1:</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not familiar with any of this code but I'll do my best to give a proper review later.  For now I just wanted to mention a couple things that I noticed right away.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not applying a vote because I don't want others to see the -1 and skip over the review.</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7710/1/include/asterisk/res_pjsip.h">File include/asterisk/res_pjsip.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7710/1/include/asterisk/res_pjsip.h@306">Patch Set #1, Line 306:</a> <code style="font-family:monospace,monospace">     /*! UNUSED: The round trip start time set before sending a qualify request */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The ABI of 'struct ast_sip_contact_status' is broken by removal of SORCERY_OBJECT(details) and addition of name.  Assuming that's unavailable why not also remove rtt_start and refresh?  If these fields will be used again in the future of 13 then lets say 'RESERVED' instead of 'UNUSED'.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7710/1/res/res_pjsip/pjsip_options.c">File res/res_pjsip/pjsip_options.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7710/1/res/res_pjsip/pjsip_options.c">Patch Set #1:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">sip_contact_hash and sip_contact_cmp can be replaced by ast_sorcery_object_id_hash and ast_sorcery_object_id_compare.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The remaining container hash/cmp functions can be generated by macro's AO2_STRING_FIELD_HASH_FN and AO2_STRING_FIELD_CMP_FN.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7710">change 7710</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7710"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6a5ebbfca9001dfe933eaeac4d3babd8d2e6f082 </div>
<div style="display:none"> Gerrit-Change-Number: 7710 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 25 Dec 2017 16:44:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>