[Asterisk-code-review] channels/SIP/ami/sip notify/call id: 3PCC patch for AMI "SIP... (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7705 )

Change subject: channels/SIP/ami/sip_notify/call_id: 3PCC patch for AMI "SIPnotify".
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7705/2/tests/channels/SIP/ami/sip_notify/call_id/sipp/callee.xml
File tests/channels/SIP/ami/sip_notify/call_id/sipp/callee.xml:

https://gerrit.asterisk.org/#/c/7705/2/tests/channels/SIP/ami/sip_notify/call_id/sipp/callee.xml@61
PS2, Line 61:     <send>
I'm unsure why we want to send '200 OK' twice in a row?  I think we probably want a SIP BYE to hangup the channel after receiving the NOTIFY.

You'll notice that if you run all 3 of tests/channels/SIP/ami/sip_notify/* your test takes much longer than the other two.  I think that's because you are not hanging up the channel so things are stalling when it's time to shutdown.



-- 
To view, visit https://gerrit.asterisk.org/7705
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idccbf32ed6670a5205ee99bd7413c7fe0804efb1
Gerrit-Change-Number: 7705
Gerrit-PatchSet: 2
Gerrit-Owner: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Sun, 24 Dec 2017 17:57:53 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171224/20f03743/attachment.html>