<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7705">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7705/2/tests/channels/SIP/ami/sip_notify/call_id/sipp/callee.xml">File tests/channels/SIP/ami/sip_notify/call_id/sipp/callee.xml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7705/2/tests/channels/SIP/ami/sip_notify/call_id/sipp/callee.xml@61">Patch Set #2, Line 61:</a> <code style="font-family:monospace,monospace">    <send></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm unsure why we want to send '200 OK' twice in a row?  I think we probably want a SIP BYE to hangup the channel after receiving the NOTIFY.</p><p style="white-space: pre-wrap; word-wrap: break-word;">You'll notice that if you run all 3 of tests/channels/SIP/ami/sip_notify/* your test takes much longer than the other two.  I think that's because you are not hanging up the channel so things are stalling when it's time to shutdown.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7705">change 7705</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7705"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idccbf32ed6670a5205ee99bd7413c7fe0804efb1 </div>
<div style="display:none"> Gerrit-Change-Number: 7705 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Yasuhiko Kamata <yasuhiko.kamata@nxtg.co.jp> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 24 Dec 2017 17:57:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>