[Asterisk-code-review] app voicemail: Fix file copy error handling. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/7702 )

Change subject: app_voicemail: Fix file copy error handling.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/7702/1/apps/app_voicemail.c
File apps/app_voicemail.c:

https://gerrit.asterisk.org/#/c/7702/1/apps/app_voicemail.c@4656
PS1, Line 4656: 	if (!link(infile, outfile)) {
Just a nit, still +1ing...
if (!link(infile, outfile)) always gives me the impression "if link fails" whereas if (link(infile, outfile) == 0) reminds me that we're checking the return code.



-- 
To view, visit https://gerrit.asterisk.org/7702
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5140b60cb7de79e3d5d92be3c256947aa99da9
Gerrit-Change-Number: 7702
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Thu, 21 Dec 2017 14:37:14 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171221/1baa1314/attachment.html>