<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7702">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7702/1/apps/app_voicemail.c">File apps/app_voicemail.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7702/1/apps/app_voicemail.c@4656">Patch Set #1, Line 4656:</a> <code style="font-family:monospace,monospace">        if (!link(infile, outfile)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Just a nit, still +1ing...<br>if (!link(infile, outfile)) always gives me the impression "if link fails" whereas if (link(infile, outfile) == 0) reminds me that we're checking the return code.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7702">change 7702</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7702"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iba5140b60cb7de79e3d5d92be3c256947aa99da9 </div>
<div style="display:none"> Gerrit-Change-Number: 7702 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 21 Dec 2017 14:37:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>