[Asterisk-code-review] loader: Use vector to build apha sorted module lists. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7521 )

Change subject: loader: Use vector to build apha sorted module lists.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/7521/2/main/loader.c
File main/loader.c:

https://gerrit.asterisk.org/#/c/7521/2/main/loader.c@1558
PS2, Line 1558: 	if (AST_DLLIST_TRYLOCK(&module_list)) {
              : 		unlock = 0;
              : 	}
Oh my.  If we couldn't get the lock we should not be continuing.  Though the question is why are we not just locking?


https://gerrit.asterisk.org/#/c/7521/2/main/loader.c@1573
PS2, Line 1573: 	AST_VECTOR_FREE(&alpha_module_list);
To be consistent, you could free after unlocking like the others.



-- 
To view, visit https://gerrit.asterisk.org/7521
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c519f4dec3cda98b2f34d314255a31d49a6a467
Gerrit-Change-Number: 7521
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 15 Dec 2017 02:00:24 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171214/ed9757d7/attachment.html>