<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7521">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7521/2/main/loader.c">File main/loader.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7521/2/main/loader.c@1558">Patch Set #2, Line 1558:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">     if (AST_DLLIST_TRYLOCK(&module_list)) {<br>           unlock = 0;<br>   }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Oh my.  If we couldn't get the lock we should not be continuing.  Though the question is why are we not just locking?</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7521/2/main/loader.c@1573">Patch Set #2, Line 1573:</a> <code style="font-family:monospace,monospace">       AST_VECTOR_FREE(&alpha_module_list);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">To be consistent, you could free after unlocking like the others.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7521">change 7521</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7521"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9c519f4dec3cda98b2f34d314255a31d49a6a467 </div>
<div style="display:none"> Gerrit-Change-Number: 7521 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 15 Dec 2017 02:00:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>