[Asterisk-code-review] secure calling: Add nominal call tests (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7474 )

Change subject: secure_calling:  Add nominal call tests
......................................................................


Patch Set 2: Code-Review-1

(10 comments)

https://gerrit.asterisk.org/#/c/7474/2/configs/keys/README.txt
File configs/keys/README.txt:

https://gerrit.asterisk.org/#/c/7474/2/configs/keys/README.txt@3
PS2, Line 3: keys and certs. 
red blob


https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/configs/ast3/extensions.conf
File tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/configs/ast3/extensions.conf:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/configs/ast3/extensions.conf@1
PS2, Line 1: ; I'm bob.  
redness


https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/test-config.yaml
File tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/test-config.yaml:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/test-config.yaml@85
PS2, Line 85:     minversion: '12.0.0'
Is this minversion true?


https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/configs/ast3/extensions.conf
File tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/configs/ast3/extensions.conf:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/configs/ast3/extensions.conf@1
PS2, Line 1: ; I'm bob.  
extra spaces at end.


https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/test-config.yaml
File tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/test-config.yaml:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/test-config.yaml@87
PS2, Line 87:     minversion: '12.0.0'
minversion correct?


https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/tests.yaml
File tests/channels/pjsip/secure_calling/calls/nominal/tests.yaml:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/tests.yaml@6
PS2, Line 6:     
moar redness!


https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/configs/ast3/extensions.conf
File tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/configs/ast3/extensions.conf:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/configs/ast3/extensions.conf@1
PS2, Line 1: ; I'm bob.  
Some more red


https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/test-config.yaml
File tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/test-config.yaml:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/test-config.yaml@89
PS2, Line 89:     minversion: '12.0.0'
Minversion question again?


https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/configs/ast3/extensions.conf
File tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/configs/ast3/extensions.conf:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/configs/ast3/extensions.conf@1
PS2, Line 1: ; I'm bob.  
Last redness?


https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/test-config.yaml
File tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/test-config.yaml:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/test-config.yaml@91
PS2, Line 91:     minversion: '12.0.0'
minversion?



-- 
To view, visit https://gerrit.asterisk.org/7474
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id25b4811ed075223ed77635a25e04e2d3abb4e55
Gerrit-Change-Number: 7474
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 13 Dec 2017 17:51:35 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171213/d4b81057/attachment.html>