<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7474">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(10 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7474/2/configs/keys/README.txt">File configs/keys/README.txt:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7474/2/configs/keys/README.txt@3">Patch Set #2, Line 3:</a> <code style="font-family:monospace,monospace">keys and certs. </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">red blob</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/configs/ast3/extensions.conf">File tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/configs/ast3/extensions.conf:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/configs/ast3/extensions.conf@1">Patch Set #2, Line 1:</a> <code style="font-family:monospace,monospace">; I'm bob.  </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">redness</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/test-config.yaml">File tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/test-config.yaml@85">Patch Set #2, Line 85:</a> <code style="font-family:monospace,monospace">    minversion: '12.0.0'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is this minversion true?</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/configs/ast3/extensions.conf">File tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/configs/ast3/extensions.conf:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/configs/ast3/extensions.conf@1">Patch Set #2, Line 1:</a> <code style="font-family:monospace,monospace">; I'm bob.  </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">extra spaces at end.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/test-config.yaml">File tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/test-config.yaml@87">Patch Set #2, Line 87:</a> <code style="font-family:monospace,monospace">    minversion: '12.0.0'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">minversion correct?</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/tests.yaml">File tests/channels/pjsip/secure_calling/calls/nominal/tests.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/tests.yaml@6">Patch Set #2, Line 6:</a> <code style="font-family:monospace,monospace">    </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">moar redness!</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/configs/ast3/extensions.conf">File tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/configs/ast3/extensions.conf:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/configs/ast3/extensions.conf@1">Patch Set #2, Line 1:</a> <code style="font-family:monospace,monospace">; I'm bob.  </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Some more red</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/test-config.yaml">File tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/test-config.yaml@89">Patch Set #2, Line 89:</a> <code style="font-family:monospace,monospace">    minversion: '12.0.0'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Minversion question again?</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/configs/ast3/extensions.conf">File tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/configs/ast3/extensions.conf:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/configs/ast3/extensions.conf@1">Patch Set #2, Line 1:</a> <code style="font-family:monospace,monospace">; I'm bob.  </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Last redness?</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/test-config.yaml">File tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/test-config.yaml@91">Patch Set #2, Line 91:</a> <code style="font-family:monospace,monospace">    minversion: '12.0.0'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">minversion?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7474">change 7474</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7474"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id25b4811ed075223ed77635a25e04e2d3abb4e55 </div>
<div style="display:none"> Gerrit-Change-Number: 7474 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 13 Dec 2017 17:51:35 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>