[Asterisk-code-review] Add new AMI action for app voicemail (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/7494 )

Change subject: Add new AMI action for app_voicemail
......................................................................


Patch Set 2: Code-Review-1

(6 comments)

A couple of english corrections are needed.  Code looks mostly good though!

https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c
File apps/app_voicemail.c:

https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c@473
PS2, Line 473: 				<para>The context info of you want to check.</para>
Should this say, "The context you want to check" instead?


https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c@476
PS2, Line 476: 				<para>The mailbox info of you want to check.</para>
Should this say, "The mailbox you want to check"?


https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c@480
PS2, Line 480: 			<para>Retrieves the status of given voicemail user.</para>
This should probably say "Retrieves the status of the given voicemail user"


https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c@13301
PS2, Line 13301: 	// no any voicemail user
Technically, we don't accept C++ style comments.  You'll need to covert this and the following '//' comments to '/* */' comments.


https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c@13303
PS2, Line 13303: 		astman_send_ack(s, m, "There are no voicemail user currently defined.");
Need to update to: "There are no voicemail users currently defined."


https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c@13313
PS2, Line 13313: 		astman_send_ack(s, m, "There are no voicemail user of given info.");
Needs to be "There is no voicemail user of the given info."



-- 
To view, visit https://gerrit.asterisk.org/7494
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eba1424a142e5fbd1d9fb1821a3fc1a1e238b7
Gerrit-Change-Number: 7494
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Mon, 11 Dec 2017 20:16:25 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171211/4876495e/attachment.html>