<p>Matthew Fredrickson <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7494">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">A couple of english corrections are needed. Code looks mostly good though!</p><p>(6 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c">File apps/app_voicemail.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c@473">Patch Set #2, Line 473:</a> <code style="font-family:monospace,monospace"> <para>The context info of you want to check.</para></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should this say, "The context you want to check" instead?</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c@476">Patch Set #2, Line 476:</a> <code style="font-family:monospace,monospace"> <para>The mailbox info of you want to check.</para></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should this say, "The mailbox you want to check"?</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c@480">Patch Set #2, Line 480:</a> <code style="font-family:monospace,monospace"> <para>Retrieves the status of given voicemail user.</para></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should probably say "Retrieves the status of the given voicemail user"</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c@13301">Patch Set #2, Line 13301:</a> <code style="font-family:monospace,monospace"> // no any voicemail user</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Technically, we don't accept C++ style comments. You'll need to covert this and the following '//' comments to '/* */' comments.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c@13303">Patch Set #2, Line 13303:</a> <code style="font-family:monospace,monospace"> astman_send_ack(s, m, "There are no voicemail user currently defined.");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to update to: "There are no voicemail users currently defined."</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7494/2/apps/app_voicemail.c@13313">Patch Set #2, Line 13313:</a> <code style="font-family:monospace,monospace"> astman_send_ack(s, m, "There are no voicemail user of given info.");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Needs to be "There is no voicemail user of the given info."</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7494">change 7494</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7494"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie4eba1424a142e5fbd1d9fb1821a3fc1a1e238b7 </div>
<div style="display:none"> Gerrit-Change-Number: 7494 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 11 Dec 2017 20:16:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>