[Asterisk-code-review] pjsip: Improve CLI completion performance (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/7497 )

Change subject: pjsip: Improve CLI completion performance
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7497/1/res/res_pjsip/pjsip_cli.c
File res/res_pjsip/pjsip_cli.c:

https://gerrit.asterisk.org/#/c/7497/1/res/res_pjsip/pjsip_cli.c@96
PS1, Line 96: 		if (!strncasecmp(word, id, wordlen)) {
> Since the container comes from sorcery shouldn't we be able to use
 > prefix search to populate it?  Not saying we should hold back this
 > review but it seems worth follow-up.

That would require an API change to the ast_sip_cli_formatter_entry structure which I am not sure would be worth it. This is already a significant improvement over what we were doing before, I don't know that we'd gain a lot by pressing it forward.



-- 
To view, visit https://gerrit.asterisk.org/7497
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d802294d2ac1766110dc75f7d117c8541ce348
Gerrit-Change-Number: 7497
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Sun, 10 Dec 2017 18:59:42 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171210/566c36ed/attachment.html>