<p>Sean Bright <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7497">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7497/1/res/res_pjsip/pjsip_cli.c">File res/res_pjsip/pjsip_cli.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7497/1/res/res_pjsip/pjsip_cli.c@96">Patch Set #1, Line 96:</a> <code style="font-family:monospace,monospace">          if (!strncasecmp(word, id, wordlen)) {</code></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Since the container comes from sorcery shouldn't we be able to use<br>prefix search to populate it?  Not saying we should hold back this<br>review but it seems worth follow-up.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">That would require an API change to the ast_sip_cli_formatter_entry structure which I am not sure would be worth it. This is already a significant improvement over what we were doing before, I don't know that we'd gain a lot by pressing it forward.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7497">change 7497</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7497"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I76d802294d2ac1766110dc75f7d117c8541ce348 </div>
<div style="display:none"> Gerrit-Change-Number: 7497 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 10 Dec 2017 18:59:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>