[Asterisk-code-review] utils: Add convenience function for setting fd flags (asterisk[13])

Sean Bright asteriskteam at digium.com
Fri Dec 8 13:16:16 CST 2017


Hello Jenkins2, George Joseph, Corey Farrell, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7471

to look at the new patch set (#5).

Change subject: utils: Add convenience function for setting fd flags
......................................................................

utils: Add convenience function for setting fd flags

There are many places in the code base where we ignore the return value
of fcntl() when getting/setting file descriptior flags. This patch
introduces a convenience function that allows setting or clearing file
descriptor flags and will also log an error on failure for later
analysis.

Change-Id: I8b81901e1b1bd537ca632567cdb408931c6eded7
---
M apps/app_ices.c
M channels/chan_phone.c
M channels/chan_sip.c
M channels/vgrabbers.c
M codecs/codec_dahdi.c
M include/asterisk/utils.h
M main/alertpipe.c
M main/asterisk.c
M main/http.c
M main/manager.c
M main/tcptls.c
M main/udptl.c
M main/utils.c
M res/res_agi.c
M res/res_http_websocket.c
M res/res_musiconhold.c
M res/res_pktccops.c
M res/res_rtp_asterisk.c
M res/res_timing_pthread.c
19 files changed, 103 insertions(+), 104 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/71/7471/5
-- 
To view, visit https://gerrit.asterisk.org/7471
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8b81901e1b1bd537ca632567cdb408931c6eded7
Gerrit-Change-Number: 7471
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171208/d665d4eb/attachment.html>


More information about the asterisk-code-review mailing list