[Asterisk-code-review] utils: Add convenience function for setting fd flags (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7471 )

Change subject: utils: Add convenience function for setting fd flags
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/7471/4/include/asterisk/utils.h
File include/asterisk/utils.h:

https://gerrit.asterisk.org/#/c/7471/4/include/asterisk/utils.h@1182
PS4, Line 1182: int _ast_fd_set_flags(int fd, int flags, enum ast_fd_flag_operation op,
By "debug variant" I meant the actual function which accepts caller file/line/func since those arguments are for logging only.

About the _ast vs __ast I don't feel very strongly but it's worth mentioning that in 15+ most of the _ast functions were renamed to __ast (all except _ast_assert).  If you do make the change I'd appreciate you also reordering the parameters: file, line, func to match most other stuff.



-- 
To view, visit https://gerrit.asterisk.org/7471
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b81901e1b1bd537ca632567cdb408931c6eded7
Gerrit-Change-Number: 7471
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 08 Dec 2017 19:09:53 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171208/adce0bf5/attachment-0001.html>