[Asterisk-code-review] sounds index: Avoid repeatedly reindexing. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7454 )

Change subject: sounds_index: Avoid repeatedly reindexing.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

-1 just so it is seen.

https://gerrit.asterisk.org/#/c/7454/1/main/sounds_index.c
File main/sounds_index.c:

https://gerrit.asterisk.org/#/c/7454/1/main/sounds_index.c@317
PS1, Line 317: int ast_sounds_index_init(void)
You might want to move calling ast_sounds_index_init() to just before fully booted is declared in asterisk.c.  This way the index is fully created before things try to use it after fully booted.  You also won't need this temporary stasis subscription.

The testsuite is likely to care about this on faster machines.



-- 
To view, visit https://gerrit.asterisk.org/7454
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I585fd6ee04200612ab1490dc804f76805f89cf0a
Gerrit-Change-Number: 7454
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 06 Dec 2017 21:53:45 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171206/d3ac7c5e/attachment.html>