<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7454">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">-1 just so it is seen.</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7454/1/main/sounds_index.c">File main/sounds_index.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7454/1/main/sounds_index.c@317">Patch Set #1, Line 317:</a> <code style="font-family:monospace,monospace">int ast_sounds_index_init(void)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You might want to move calling ast_sounds_index_init() to just before fully booted is declared in asterisk.c.  This way the index is fully created before things try to use it after fully booted.  You also won't need this temporary stasis subscription.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The testsuite is likely to care about this on faster machines.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7454">change 7454</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7454"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I585fd6ee04200612ab1490dc804f76805f89cf0a </div>
<div style="display:none"> Gerrit-Change-Number: 7454 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 06 Dec 2017 21:53:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>