[Asterisk-code-review] Workaround for wrong identity in dialog package XML in notify. (asterisk[13])

[Thierry Magnien]

Thierry Magnien has posted comments on this change. ( https://gerrit.asterisk.org/6209 )

Change subject: Workaround for wrong identity in dialog package XML in notify.
......................................................................


Patch Set 1:

Hi Joshua and thanks for reviewing my code.
I'm not an Asterisk expert so I just followed source code until I discovered that the dialog is sent when device is ringing but underlying channel is not in ringing state yet. After some tests I found out that when channel reaches ringing state, a message is prepared but not sent because it's not an "aggregate" message (which I must admit I don't understant what it means). I simply added an exception so that the message is sent.
About the line 15276, it avoids providing wrong information and from what I inderstand of the RFC, the dialog-info XML is still valid as field is optional.
Hope this clarifies things.
Regards,
Thierry


-- 
To view, visit https://gerrit.asterisk.org/6209
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31ef1b6dcb9e844b2c1612e634c2a5b88906724
Gerrit-Change-Number: 6209
Gerrit-PatchSet: 1
Gerrit-Owner: Thierry Magnien <thierry.magnien at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Thierry Magnien <thierry.magnien at gmail.com>
Gerrit-Comment-Date: Tue, 29 Aug 2017 08:02:58 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170829/0805e3dc/attachment.html>