[Asterisk-code-review] Workaround for wrong identity in dialog package XML in notify. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6209 )

Change subject: Workaround for wrong identity in dialog package XML in notify.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I'm not comfortable with this going in as a workaround until we understand the exact flow of things that led you to it. Specifically the device state transitions that occur and when. Is it that internally multiple ringing device updates occur but as one already occurred it does not propagate down to chan_sip? (When it actually can get the ringing channel)? So you let them all through and squash the useless ones when sending the NOTIFY?

https://gerrit.asterisk.org/#/c/6209/1/channels/chan_sip.c
File channels/chan_sip.c:

https://gerrit.asterisk.org/#/c/6209/1/channels/chan_sip.c@15276
PS1, Line 15276: 					break;
Doesn't this result in an invalid dialog-info XML being sent?



-- 
To view, visit https://gerrit.asterisk.org/6209
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31ef1b6dcb9e844b2c1612e634c2a5b88906724
Gerrit-Change-Number: 6209
Gerrit-PatchSet: 1
Gerrit-Owner: Thierry Magnien <thierry.magnien at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 28 Aug 2017 12:34:27 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170828/2732ce13/attachment.html>