[Asterisk-code-review] core: Reduce video update queueing. (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6317 )

Change subject: core: Reduce video update queueing.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/6317/1/main/channel.c
File main/channel.c:

https://gerrit.asterisk.org/#/c/6317/1/main/channel.c@1100
PS1, Line 1100: 		case AST_CONTROL_VIDUPDATE:
> I did it in case something else externally was queueing rapidly (such as a 
I'd rather not go down the slippery slope of adding unnecessary intelligence to the frame queue code here.  If a channel driver or some such entity queues a bunch of these frames that shouldn't be a problem on a channel being serviced regularly.  The problem was with autoservice saving them off and then flooding the queue when the channel was reclaimed.

This change effectively makes that control frame unqueueable as it discards all of those frames.


https://gerrit.asterisk.org/#/c/6317/1/main/core_unreal.c
File main/core_unreal.c:

https://gerrit.asterisk.org/#/c/6317/1/main/core_unreal.c@329
PS1, Line 329: 	if (f->frametype == AST_FRAME_VOICE) {
             : 		if (!ast_channel_get_default_stream(ast, AST_MEDIA_TYPE_AUDIO)) {
> They aren't audio specific and they occur much less frequently than video u
I can see why it shouldn't be changed here but autoservice shouldn't accumulate them for the exact same reason as AST_CONTROL_VIDUPDATE.



-- 
To view, visit https://gerrit.asterisk.org/6317
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3f40a6f51b740ae4704003a1800185c0c658ee7
Gerrit-Change-Number: 6317
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 28 Aug 2017 15:59:00 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170828/32b78312/attachment.html>