[Asterisk-code-review] core: Reduce video update queueing. (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6317 )

Change subject: core: Reduce video update queueing.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/6317/1/main/channel.c
File main/channel.c:

https://gerrit.asterisk.org/#/c/6317/1/main/channel.c@1100
PS1, Line 1100: 		case AST_CONTROL_VIDUPDATE:
> Why is this being blocked?  I'd think that the autoservice change would pre
I did it in case something else externally was queueing rapidly (such as a channel driver) needlessly.


https://gerrit.asterisk.org/#/c/6317/1/main/core_unreal.c
File main/core_unreal.c:

https://gerrit.asterisk.org/#/c/6317/1/main/core_unreal.c@329
PS1, Line 329: 	if (f->frametype == AST_FRAME_VOICE) {
             : 		if (!ast_channel_get_default_stream(ast, AST_MEDIA_TYPE_AUDIO)) {
> Should also drop the AST_CONTROL_SRCUPDATE and AST_CONTROL_SRCCHANGE frames
They aren't audio specific and they occur much less frequently than video update. I'd also prefer to keep this patch specific to video update since that was the original issue.



-- 
To view, visit https://gerrit.asterisk.org/6317
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3f40a6f51b740ae4704003a1800185c0c658ee7
Gerrit-Change-Number: 6317
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Sun, 27 Aug 2017 23:41:22 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170827/a0496227/attachment.html>