[Asterisk-code-review] rls test.py: Allow setting of reactor timeout (testsuite[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6216 )

Change subject: rls_test.py:  Allow setting of reactor timeout
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/6216/1/tests/channels/pjsip/subscriptions/rls/rls_test.py
File tests/channels/pjsip/subscriptions/rls/rls_test.py:

https://gerrit.asterisk.org/#/c/6216/1/tests/channels/pjsip/subscriptions/rls/rls_test.py@84
PS1, Line 84:         test_object.reactor_timeout = module_config.get("reactor-timeout", 30)
Why can't this be done at a common level instead of this specific plug-in module?  In the test you mentioned elsewhere (tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/batched/single_resource_multiple_changes/test_config.yaml) the test_object is created by sipp.SIPpTestCase.  I'd think that the reactor_timeout should be an available option for all tests.



-- 
To view, visit https://gerrit.asterisk.org/6216
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I133e437a7ee5b5e423bd58399873ac96df63a8d4
Gerrit-Change-Number: 6216
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 10 Aug 2017 21:21:24 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170810/5a39424f/attachment.html>