<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6216">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6216/1/tests/channels/pjsip/subscriptions/rls/rls_test.py">File tests/channels/pjsip/subscriptions/rls/rls_test.py:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6216/1/tests/channels/pjsip/subscriptions/rls/rls_test.py@84">Patch Set #1, Line 84:</a> <code style="font-family:monospace,monospace">        test_object.reactor_timeout = module_config.get("reactor-timeout", 30)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why can't this be done at a common level instead of this specific plug-in module?  In the test you mentioned elsewhere (tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/batched/single_resource_multiple_changes/test_config.yaml) the test_object is created by sipp.SIPpTestCase.  I'd think that the reactor_timeout should be an available option for all tests.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6216">change 6216</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6216"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I133e437a7ee5b5e423bd58399873ac96df63a8d4 </div>
<div style="display:none"> Gerrit-Change-Number: 6216 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 10 Aug 2017 21:21:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>