[Asterisk-code-review] chan sip.c: Fix to stop MOH playing on held channel during a... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6124 )

Change subject: chan_sip.c:	Fix to stop MOH playing on held channel during attended transfer
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

For more context: In previous versions of Asterisk there was no core transfer code, so it was up to the individual channel drivers to do things. Since there is now core support the logic lives there.

https://gerrit.asterisk.org/#/c/6124/1/channels/chan_sip.c
File channels/chan_sip.c:

https://gerrit.asterisk.org/#/c/6124/1/channels/chan_sip.c@25627
PS1, Line 25627: 		AST_LIST_TRAVERSE(&bridge->channels, other, entry) {
This is the responsibility of the core attended transfer and bridge code to do, and in fact it already does it in places. I think more investigation is needed to find the precise code path and scenario under which it is not working.

Additionally this is unsafe to do here, as without the bridge lock being held you can't be guaranteed that the list of channels won't change.



-- 
To view, visit https://gerrit.asterisk.org/6124
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a373263d92cf27c513013baefdd72ae1864c2ce
Gerrit-Change-Number: 6124
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Tomlinson <j.tomlinson at isi-com.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 07 Aug 2017 12:12:39 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170807/7684727b/attachment.html>