<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6124">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">For more context: In previous versions of Asterisk there was no core transfer code, so it was up to the individual channel drivers to do things. Since there is now core support the logic lives there.</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6124/1/channels/chan_sip.c">File channels/chan_sip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6124/1/channels/chan_sip.c@25627">Patch Set #1, Line 25627:</a> <code style="font-family:monospace,monospace">         AST_LIST_TRAVERSE(&bridge->channels, other, entry) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is the responsibility of the core attended transfer and bridge code to do, and in fact it already does it in places. I think more investigation is needed to find the precise code path and scenario under which it is not working.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Additionally this is unsafe to do here, as without the bridge lock being held you can't be guaranteed that the list of channels won't change.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6124">change 6124</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6124"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6a373263d92cf27c513013baefdd72ae1864c2ce </div>
<div style="display:none"> Gerrit-Change-Number: 6124 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jason Tomlinson <j.tomlinson@isi-com.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 07 Aug 2017 12:12:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>