[Asterisk-code-review] chan sip: Access incoming REFER headers in dialplan (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6118 )

Change subject: chan_sip: Access incoming REFER headers in dialplan
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

* Documentation of how this feature works is needed in sip.conf.sample.

* A note about the addition of this feature is needed in the CHANGES file.

https://gerrit.asterisk.org/#/c/6118/2/channels/chan_sip.c
File channels/chan_sip.c:

https://gerrit.asterisk.org/#/c/6118/2/channels/chan_sip.c@18643
PS2, Line 18643: 				struct ast_str *pbxvar = ast_str_alloca(120);
Using ast_str_alloca() inside a loop can conceivably cause a crash because you keep allocating from the stack for each loop iteration.  In this case you just need to move the declaration out of the for loop.



-- 
To view, visit https://gerrit.asterisk.org/6118
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73d7a1e95981693bc59aa0d5093c074b555f708e
Gerrit-Change-Number: 6118
Gerrit-PatchSet: 2
Gerrit-Owner: Kirill Katsnelson <kkm at smartaction.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 01 Aug 2017 18:27:39 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170801/1b6a18ea/attachment.html>