<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6118">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><ul><li>Documentation of how this feature works is needed in sip.conf.sample.</li></ul><ul><li>A note about the addition of this feature is needed in the CHANGES file.</li></ul><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6118/2/channels/chan_sip.c">File channels/chan_sip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6118/2/channels/chan_sip.c@18643">Patch Set #2, Line 18643:</a> <code style="font-family:monospace,monospace">                              struct ast_str *pbxvar = ast_str_alloca(120);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Using ast_str_alloca() inside a loop can conceivably cause a crash because you keep allocating from the stack for each loop iteration.  In this case you just need to move the declaration out of the for loop.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6118">change 6118</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6118"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I73d7a1e95981693bc59aa0d5093c074b555f708e </div>
<div style="display:none"> Gerrit-Change-Number: 6118 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Kirill Katsnelson <kkm@smartaction.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 01 Aug 2017 18:27:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>