[Asterisk-code-review] asterisk.c: Non-root users also get the astcanary after core... (asterisk[master])

[Walter Doekes]

Walter Doekes has posted comments on this change.

Change subject: asterisk.c: Non-root users also get the astcanary after core restart.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/3920/3/main/asterisk.c
File main/asterisk.c:

Line 1795: 	return (getpriority(PRIO_PROCESS, 0) < 0 && errno == 0);
> One more thought about this, although it should be impossible for getpriori
While that sounds like a safe option, I'm inclined to say that if we cannot query, we probably won't be able to influence the setting either. And ^U^U^U

Or not.. perhaps querying is broken while setting is not. And an extra canary won't hurt a non-realtime system.

I'll go change it (and rebase, which I should anyway).


-- 
To view, visit https://gerrit.asterisk.org/3920
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb49f26491a0717084ad46ed96b0bea5f627a55
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-HasComments: Yes