[Asterisk-code-review] asterisk.c: Non-root users also get the astcanary after core... (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: asterisk.c: Non-root users also get the astcanary after core restart.
......................................................................


Patch Set 3:

(1 comment)

I'm not taking away the +1, not even sure if my comment about getpriority failure is reasonable.

https://gerrit.asterisk.org/#/c/3920/3/main/asterisk.c
File main/asterisk.c:

Line 1795: 	return (getpriority(PRIO_PROCESS, 0) < 0 && errno == 0);
One more thought about this, although it should be impossible for getpriority to fail with these parameters, oddness happens sometimes.

If this does fail, would it be safer to just assume that we are high priority and just can't query?  If we run astcanary at normal priority that's little harm (a few kb wasted memory).  If we fail to run astcanary at high priority that could could freeze the whole system.


-- 
To view, visit https://gerrit.asterisk.org/3920
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb49f26491a0717084ad46ed96b0bea5f627a55
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-HasComments: Yes