[Asterisk-code-review] build: Add download capability for external packages (asterisk[13])
George Joseph
asteriskteam at digium.com
Thu Sep 1 09:17:31 CDT 2016
George Joseph has posted comments on this change.
Change subject: build: Add download capability for external packages
......................................................................
Patch Set 3:
> (1 comment)
>
> Mostly -1 to ensure you see my comment. Not sure the bash
> portability thing actually matters? Worth nothing that in
> build_tools everything currently uses '#!/bin/sh' or python. I
> can't say if they will actually run without bash.
I checked ubuntu14 which uses sh by default and ./configure detects bash and sets the make SHELL to it. The make install works fine.
--
To view, visit https://gerrit.asterisk.org/3769
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3dcf1289ffd3cb0bbd7dfab3cafbb87be60323a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: No
More information about the asterisk-code-review
mailing list