[Asterisk-code-review] build: Add download capability for external packages (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: build: Add download capability for external packages
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Mostly -1 to ensure you see my comment.  Not sure the bash portability thing actually matters?  Worth nothing that in build_tools everything currently uses '#!/bin/sh' or python.  I can't say if they will actually run without bash.

https://gerrit.asterisk.org/#/c/3769/3/Makefile.moddir_rules
File Makefile.moddir_rules:

Line 130: 		for x in $(MENUSELECT_$(MENUSELECT_CATEGORY)) ; do DISABLED_MODS[$${x}]=1 ; done ;\
I suspect shell array variables is bash specific?  Maybe it would be more portable to use grep or sed in the EXTERNAL_MODS loop?

On the other hand the download_externals script looks like it uses some bash specific features, maybe best to just make this require bash?


-- 
To view, visit https://gerrit.asterisk.org/3769
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3dcf1289ffd3cb0bbd7dfab3cafbb87be60323a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: Yes