[Asterisk-code-review] pjproject bundled: Add MALLOC DEBUG capability (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Fri Oct 7 16:03:33 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: pjproject_bundled:  Add MALLOC_DEBUG capability
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/4030/2/third-party/pjproject/Makefile
File third-party/pjproject/Makefile:

PS2, Line 46: 			apps := source/pjsip-apps/bin/pjsua-$(TARGET_NAME) source/pjsip-apps/bin/pjsystest-$(TARGET_NAME)
            :             TARGETS += $(apps)
            :             ifneq ($(PYTHONDEV_LIB),)
            :             	PYTHON_BINDING_DIR := $(shell python -c 'import platform;print("lib.%s-%s-%s" % (platform.system().lower(), platform.machine(), platform.python_version().rsplit(".",1)[0]))')
inconsistent whitespace indentation


Line 120: # so we separate them out and create the dependencies 
Oh, there are red blobs in this file.


-- 
To view, visit https://gerrit.asterisk.org/4030
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc5e3d658fbfb00e0a46b44c66dcc2522d5171b0
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list