[Asterisk-code-review] pjproject bundled: Add MALLOC DEBUG capability (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: pjproject_bundled:  Add MALLOC_DEBUG capability
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

make[3]: Entering directory `/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/src/python'
python setup.py build
running build
running build_py
running build_ext
building '_pjsua' extension
gcc -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -pthread -pipe -g3 -O0 -DMALLOC_DEBUG -fPIC -DPJ_AUTOCONF=1 -Imake[4]: Entering directory `/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/src/python' -I/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjlib/include -I/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjlib-util/include -I/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjnath/include -I/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjmedia/include -I/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip/include -Imake[4]: Leaving directory `/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/src/python' -I/usr/include/python2.7 -c _pjsua.c -o build/temp.linux-i686-2.7/_pjsua.o
_pjsua.c: In function ‘py_pjsua_enum_transports’:
_pjsua.c:1202:17: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
_pjsua.c: In function ‘py_pjsua_conf_get_port_info’:
_pjsua.c:2338:9: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
_pjsua.c: In function ‘py_pjsua_get_snd_dev’:
_pjsua.c:2714:9: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
warning: no library file corresponding to 'make[4]: Entering directory `/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/src/python'' found (skipping)
warning: no library file corresponding to 'make[4]: Leaving directory `/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/src/python'' found (skipping)
gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-whole-archive -L/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib -lasterisk_malloc_debug -Wl,-no-whole-archive -Wl,-whole-archive -L/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib -lasterisk_malloc_debug -Wl,-no-whole-archive -pthread -pipe -g3 -O0 -DMALLOC_DEBUG build/temp.linux-i686-2.7/_pjsua.o -Lmake[4]: Entering directory `/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/src/python' -L/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjlib/lib -L/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjlib-util/lib -L/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjnath/lib -L/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjmedia/lib -L/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip/lib -L/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/third_party/lib -Lmake[4]: Leaving directory `/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/src/python' -lpjsua-i686-pc-linux-gnu -lpjsip-ua-i686-pc-linux-gnu -lpjsip-simple-i686-pc-linux-gnu -lpjsip-i686-pc-linux-gnu -lpjmedia-codec-i686-pc-linux-gnu -lpjmedia-i686-pc-linux-gnu -lpjmedia-videodev-i686-pc-linux-gnu -lpjmedia-audiodev-i686-pc-linux-gnu -lpjmedia-i686-pc-linux-gnu -lpjnath-i686-pc-linux-gnu -lpjlib-util-i686-pc-linux-gnu -lsrtp -lpj-i686-pc-linux-gnu -lssl -lcrypto -luuid -lm -lrt -lpthread -o build/lib.linux-i686-2.7/_pjsua.so
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o): In function `__ast_asprintf':
asterisk_malloc_debug.c:(.text+0x0): multiple definition of `__ast_asprintf'
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o):asterisk_malloc_debug.c:(.text+0x0): first defined here
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o): In function `__ast_calloc':
asterisk_malloc_debug.c:(.text+0x40): multiple definition of `__ast_calloc'
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o):asterisk_malloc_debug.c:(.text+0x40): first defined here
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o): In function `__ast_free':
asterisk_malloc_debug.c:(.text+0x70): multiple definition of `__ast_free'
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o):asterisk_malloc_debug.c:(.text+0x70): first defined here
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o): In function `__ast_malloc':
asterisk_malloc_debug.c:(.text+0x90): multiple definition of `__ast_malloc'
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o):asterisk_malloc_debug.c:(.text+0x90): first defined here
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o): In function `__ast_realloc':
asterisk_malloc_debug.c:(.text+0xb0): multiple definition of `__ast_realloc'
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o):asterisk_malloc_debug.c:(.text+0xb0): first defined here
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o): In function `__ast_strdup':
asterisk_malloc_debug.c:(.text+0xe0): multiple definition of `__ast_strdup'
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o):asterisk_malloc_debug.c:(.text+0xe0): first defined here
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o): In function `__ast_strndup':
asterisk_malloc_debug.c:(.text+0x100): multiple definition of `__ast_strndup'
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o):asterisk_malloc_debug.c:(.text+0x100): first defined here
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o): In function `__ast_vasprintf':
asterisk_malloc_debug.c:(.text+0x130): multiple definition of `__ast_vasprintf'
/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/lib/libasterisk_malloc_debug.a(asterisk_malloc_debug.o):asterisk_malloc_debug.c:(.text+0x130): first defined here
collect2: ld returned 1 exit status
error: command 'gcc' failed with exit status 1
make[3]: *** [all] Error 1
make[3]: Leaving directory `/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject/source/pjsip-apps/src/python'
make[2]: *** [source/pjsip-apps/src/python/build/lib.linux-i686-2.7/_pjsua.so] Error 2
make[2]: Leaving directory `/home/rmudgett/projects/asterisk/mrg/v13/third-party/pjproject'
make[1]: *** [pjproject] Error 2
make[1]: Leaving directory `/home/rmudgett/projects/asterisk/mrg/v13/third-party'
make: *** [third-party] Error 2

https://gerrit.asterisk.org/#/c/4030/2/third-party/pjproject/patches/asterisk_malloc_debug.c
File third-party/pjproject/patches/asterisk_malloc_debug.c:

Line 28: 	int rc = 0;
rc does not need to be initialized.


-- 
To view, visit https://gerrit.asterisk.org/4030
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc5e3d658fbfb00e0a46b44c66dcc2522d5171b0
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes