[Asterisk-code-review] res rtp: Fix regression when IPv6 is not available. (asterisk[master])

[Guido Falsi]

Guido Falsi has posted comments on this change. ( https://gerrit.asterisk.org/4487 )

Change subject: res_rtp: Fix regression when IPv6 is not available.
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/4487/5/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

Line 1527: 	prm.tp_type = PJSIP_TRANSPORT_UDP6;
> You can't check for just UDP6 because you can also have TCP6 and TLS6.
While I agree should I check for all three to be active (and condition) or at least one to be active? (or condition) I'm not sure which of the two is the correct logic in this case.

RTP is really only defined as an UDP protocol AFAIK.

Regarding the PJSIP thread, I am not this well versed in the asterisk source code, can you get me a pointer to the relevant documentation so I can cut the time needed to find out myself?


-- 
To view, visit https://gerrit.asterisk.org/4487
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627a4e91795e821111e1cda523f083a40d0e0c3e
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes